fix NaN is lexed as identifier, not as a number
#397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
approved these changes
May 13, 2020
jasonwilliams
approved these changes
May 13, 2020
|
yep, looks good |
HalidOdat
approved these changes
May 13, 2020
Merged
|
This is fine as a hack, but NaN is actually specified as a global variable, like undefined, not a keyword, like null. (JavaScript is terrible.) |
Yep, we will have to improve this in the future, but first, we need to improve the lexer, the current one is a bit difficult to follow, it became too big. I opened #421 regarding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #393.
It changes the following: